[Bug 596449] Review Request: NetworkManager-openswan - NetworkManager VPN plugin for Openswan (IPsec)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596449

--- Comment #17 from Chen Lei <supercyper1@xxxxxxxxx> 2010-05-29 00:37:32 EDT ---
(In reply to comment #16)
> Chen Lei, will you do the formal review?    

I plan to do so :)

Is there anyone to help me to check whether the shared-mime-info dependency is
needed for NM plugins? I don't understand  why all NM plugins require
shared-mime-info. If all NM plugins requires mime info why not to add it to NM
instead of plugins?


Some more suggestions:
It'll better to add --disable-static to %configure, thus rm -f
%{buildroot}%{_libdir}/NetworkManager/lib*.a is not needed in spec.

From
http://cvs.fedoraproject.org/viewvc/rpms/NetworkManager-pptp/devel/NetworkManager-pptp.spec?revision=1.22&view=co

I found that desktop file and icons are commended out in spec, %post and
%postun seems unnecessary.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]