Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #23 from David Cantrell <dcantrell@xxxxxxxxxx> 2010-05-28 15:34:23 EDT --- I've updated the spec file with the latest comments. Changes: 1) I renamed the logrotate source file to wicd.logrotate per comment #22. This is really only a niceness things for people doing local rpmbuilds as it won't matter when the package is built in koji since each package is built in a new mock buildroot. 2) pm-utils >= 1.2.4 was already required by the main wicd package (comment #20). But based on comment #21, I am ok with removing this requirement since the directory is owned by filesystem and not requiring pm-utils would allow users to disable the pm-utils functionality in wicd based on whether or not pm-utils is installed. Let me know. 3) The spec file now requires ethtool for wicd-common and was already requiring iproute and net-tools. Despite the fact that Debian says ethtool and iproute are alternatives to net-tools, I don't mind requiring them all because it seems like something wicd is very likely to change in future releases since the program functions primarily based on parsing output of these commands. These are all core packages that people are almost definitely going to have on their system anyway. 4) I have corrected the Python she-bang problem per comment #17. 5) The wicd-gtk package requires pygtk2-libglade instead of pygtk2. 6) I do not feel the acpi scripts are necessary, so I did not include them. The pm-utils package provides that functionality for us in Fedora. 7) I am pretty sure there is nothing I can do about the SELinux noise you are seeing. I think the SELinux policy will have to change for that. Thanks for the review feedback! New spec and srpm uploaded: http://dcantrel.fedorapeople.org/wicd/wicd.spec http://dcantrel.fedorapeople.org/wicd/wicd-1.7.0-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review