Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #4 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2010-05-27 18:51:31 EDT --- Thanks - this is looking good. There are a couple of issues I think need fixing: (i) Please fix the python-bytecode-inconsistent-mtime" from pylint as this will make "import pyjd" slower than it could be (ii) Please fix the "License" metadata (see below) Details: NEEDSWORK: rpmlint must be run on every package. The output should be posted in the review.[1] $ rpmlint ~/rpmbuild/RPMS/noarch/pyjamas-*0.7-3* pyjamas.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyjs/pyjampiler.py 0644L /usr/bin/python pyjamas.noarch: E: non-executable-script /usr/share/pyjamas/pyjs/tests/test-coverage.py 0644L /usr/bin/env pyjamas.noarch: E: non-executable-script /usr/share/pyjamas/pyjs/src/pyjs/lib/base64.py 0644L /usr/bin/env pyjamas.noarch: E: zero-length /usr/share/pyjamas/library/jsonrpc/json.py pyjamas-desktop.noarch: W: no-documentation pyjamas-desktop.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/python2.6/site-packages/pyjd/__init__.pyc 2010-05-27T18:07:12 /usr/lib/python2.6/site-packages/pyjd/__init__.py 2010-05-27T18:07:14 pyjamas-desktop.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyjd/idlparser.py 0644L /usr/bin/env pyjamas-desktop.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyjd/modcompile.py 0644L /usr/bin/env pyjamas-desktop.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyjd/pywebkitgtk.py 0644L /usr/bin/env pyjamas-doc.noarch: W: no-documentation pyjamas-examples.noarch: W: no-documentation pyjamas-examples.noarch: E: zero-length /usr/share/pyjamas/examples/uitest/public/testLabelAdd.removelabel.txt pyjamas-examples.noarch: E: zero-length /usr/share/pyjamas/examples/maparea/Hello.py pyjamas-examples.noarch: E: zero-length /usr/share/pyjamas/examples/uitest/public/testButtonClick.removeButton.txt pyjamas-examples.noarch: E: non-executable-script /usr/share/pyjamas/examples/jsonrpc/public/PythonCGIServer.py 0644L /usr/bin/env pyjamas-examples.noarch: E: zero-length /usr/share/pyjamas/examples/maparea/Map.py pyjamas-examples.noarch: E: script-without-shebang /usr/share/pyjamas/examples/flowpanel/FlowPanel.py pyjamas-examples.noarch: E: zero-length /usr/share/pyjamas/examples/uitest/public/testDivText.removeDiv.txt pyjamas-examples.noarch: E: zero-length /usr/share/pyjamas/examples/uitest/public/testDivAdd.removeDiv.txt pyjamas-examples.noarch: E: zero-length /usr/share/pyjamas/examples/maparea/public/Hello.html pyjamas-examples.noarch: E: zero-length /usr/share/pyjamas/examples/uitest/public/testDivHTML.removeDiv.txt pyjamas-ui.noarch: W: no-documentation 5 packages and 0 specfiles checked; 18 errors, 4 warnings. Please can you fix the "python-bytecode-inconsistent-mtime" error: this will force Python to recompile pyjd/__init__.py every time you import it, if run as non-root. Everything else looks waivable to me. OK: The package must be named according to the Package Naming Guidelines OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . NEEDSWORK: The License field in the package spec file must match the actual license. [3] The file "copyright" in the source tree handily lists the licences. Most files are indeed under Apache, but there's a mixture of others: some GPL-2, Other, ZPL-2.1, MIT, PSF, LGPL-2.1. All appear to be Fedora-approved licenses. Note that each subpackage can have its own "License" tag; see https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] OK: The spec file must be written in American English. [5] OK: The spec file for the package MUST be legible. [6] OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ md5sum pyjamas-0.7.tgz pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz 8441b60bb3c88051799537852cceefd0 pyjamas-0.7.tgz 8441b60bb3c88051799537852cceefd0 pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz $ sha256sum pyjamas-0.7.tgz pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz 648f62c1ddf99392fb926ca8d3900c39109b09e06d93cc7de3668933d7084d2b pyjamas-0.7.tgz 648f62c1ddf99392fb926ca8d3900c39109b09e06d93cc7de3668933d7084d2b pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] (see scratch build in comment #0) N/A: noarch: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [8] OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. N/A: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] ./pyjd/pywebkitgtk.py uses gettext, but there don't seem to be any translations N/A: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] OK: Packages must NOT bundle copies of system libraries.[11] Special exception: there are copies of Python "system" libraries within pyjs/src/pyjs/lib - however these are there to support the JavaScript target environment, rather than CPython. These seem to end up in: /usr/share/pyjamas/pyjs/src/pyjs/lib (and of course, CPython will break horribly if this ends up in someone's PYTHONPATH, I suspect, so good to keep it segregated) N/A: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [12] OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] OK: A Fedora package must not list a file more than once in the spec file's %files listings. [14] OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [15] OK: Each package must consistently use macros. [16] OK: The package must contain code, or permissable content. [17] OK: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18] OK: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18] N/A: Header files must be in a -devel package. [19] N/A: Static libraries must be in a -static package. [20] N/A: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19] OK: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [21] N/A: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[20] OK: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [22] There are some example GUI apps, but I don't think it's worth adding a slew of .desktop files for each one. OK: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23] OK: All filenames in rpm packages must be valid UTF-8. [24] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review