Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520569 --- Comment #8 from Dan Horák <dan@xxxxxxxx> 2010-05-27 15:48:24 EDT --- (In reply to comment #7) > We need mkimage for kernel building for ARM and for the ESIA package. Thanks for the review and did you checked the uboot-tools package based on the U-Boot source code? > [N] MUST: Each package must consistently use macros. [16] > > *** Avoid mixing environment variables ($RPMBUILDROOT) with macros (e.g., use > %{buildroot}) using $RPM_BUILD_ROOT and %{_*dir} is valid, the guideline doesn't to see using both $RPM_BUILD_ROOT and %{buildroot} in one spec > [Y] MUST: The package must contain code, or permissable content. [17] > [NA] MUST: Large documentation files must go in a -doc subpackage. (The > definition of large is left up to the packager's best judgement, but is not > restricted to size. Large can refer to either size or quantity). [18] > [NA] MUST: If a package includes something as %doc, it must not affect the > runtime of the application. To summarize: If it is in %doc, the program must > run properly if it is not present. [18] > > *** !No %doc present yes, I will add some and I open to suggestions what should be included > > Additional comments: > - Should have a more detailed %desc/%summary will be updated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review