[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591730

--- Comment #3 from Kevin Fenzi <kevin@xxxxxxxxx> 2010-05-27 14:16:31 EDT ---

> I found the above specfile comment a little unclear; it looks like it was
> copied from upstream instructions, but it immediately raises questions: do the
> pyjamas libraries get installed, and if so where?

yeah, I copied this from upstream. Reworded it now. 
New wording: 

# NOTE: we only byte-compile the library files installed in the normal
# fedora python_sitelib. All other .py files are left alone. 
# This is due to those files replacing/overriding core modules. 
# They should never be run from anything but pyjamas itself, nor 
# should they be byte compiled. 

Fixed description typo. 

Changed sitelib to not use a wildcard. 

On licensing: 

- I think it does boil down to ASL2
- The pygwt.js should be ASL2 (at least google web toolkit is ASL2.0). 
- The contrib/copyright_check.py doesn't run, and I can't see how it would be
useful here, but it seems a pain to just do a special tar for this. Will ask
upstream I guess. It looks like they may have just dropped this post 0.7. 

New spec at: http://www.scrye.com/~kevin/fedora/pyjamas/pyjamas.spec

Should we ask spot to look over the licensing here? I could have missed
something...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]