Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gxine - Gnome frontend for the xine multimedia library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213511 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx ------- Additional Comments From panemade@xxxxxxxxx 2006-11-02 01:27 EST ------- rpmlint is not silent on SRPM W: kaffeine mixed-use-of-spaces-and-tabs (spaces: line 25, tab: line 16) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. W: kaffeine patch-not-applied Patch1: kaffeine-0.8.2-codecs.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. rpmlint is not silent on RPM E: kaffeine script-without-shebang /usr/share/doc/kaffeine-0.8.2/ChangeLog This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. E: kaffeine script-without-shebang /usr/share/doc/kaffeine-0.8.2/TODO This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. W: kaffeine dangling-symlink /usr/share/doc/HTML/en/kaffeine/common /usr/share/doc/HTML/en/common The symbolic link points nowhere. W: kaffeine symlink-should-be-relative /usr/share/doc/HTML/en/kaffeine/common /usr/share/doc/HTML/en/common Absolute symlinks are problematic eg. when working with chroot environments. E: kaffeine script-without-shebang /usr/share/doc/kaffeine-0.8.2/AUTHORS This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. /tmp/kaffeine-0.8.2-3.i386.rpm.26889/usr/share/applications/kde/kaffeine.desktop: warning: file contains key "DocPath", this key is currently reserved for use within KDE, and should in the future KDE releases be prefixed by "X-" Solve these errors and resubmit new package. I hope all rpmlint warnings and errros are self explanatory here. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review