Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596449 --- Comment #14 from Chen Lei <supercyper1@xxxxxxxxx> 2010-05-27 11:00:11 EDT --- Some comment: 1. Source: %{name}-%{realversion}.tar.gz Should add some comments about how to genrate the tarball See http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control 2.Epoch: 1 Remove it from spec, when possible packager should avoid of using epoch. 3. BuildRoot: %{_tmppath}/%{name}-%{version}-root Only needed for epel5 4. %post /sbin/ldconfig %postun /sbin/ldconfig It's a plugin, I don't think ldconfig is necesscery 5. %define nm_version 1:0.7.997-1 %define dbus_version 1.1 %define gtk2_version 2.10.0 %define shared_mime_version 0.16-3 Those lines are useless, all branches in fedora match those versions. 6.%{_datadir}/icons/hicolor/48x48/apps/gnome-mime-application-x-openswan-ipsec-vpn-settings.png Is this file useful for openswan? 7. %files -f %{name}.lang %defattr(-, root, root) -> %files -f %{name}.lang %defattr(-, root, root,-) 8. Requires: gtk2 >= %{gtk2_version} Requires: dbus >= %{dbus_version} Requires: shared-mime-info >= %{shared_mime_version} Requires: GConf2 Those dependicies may not need, please reconsider it, normally rpmbuild will pull in shlib depenpencies automatically. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review