Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flite - Small, fast speech synthesis engine (text-to-speech) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207793 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-01 23:28 EST ------- Created an attachment (id=140079) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=140079&action=view) Patch to try to make parallel Well, as far as I noticed by now... 1. parallel make is broken in i386, also. I sometimes fails parallel make -j3 on i386. This is because config/common_make_rules is broken. This file does not check if needed object files are already built before trying to make static ar file. Please check if my patch attached fixes the problem. 2. Well, you try to provide shared libraries which upstream doesn't by attaching a patch, do you? I have not yet checked the patch, however please make the following sure: 2-1. Please explain why the soname version '1.3' is proper. Are there any assurance that the API of the libraries won't change during 1.X version? 2-2 The shared libraries are 'partially' broken. 'Partially' means that libraries in flite includes undefined non-weak symbols. -------------------------------------------------------------------------- W: flite undefined-non-weak-symbol /usr/lib/libflite_cmu_time_awb.so.1.3 clunits_synth W: flite undefined-non-weak-symbol /usr/lib/libflite_cmu_time_awb.so.1.3 cmu_syl_boundary W: flite undefined-non-weak-symbol /usr/lib/libflite_cmu_time_awb.so.1.3 lexicon_val W: flite undefined-non-weak-symbol /usr/lib/libflite_cmu_time_awb.so.1.3 feat_set_int W: flite undefined-non-weak-symbol /usr/lib/libflite_cmu_time_awb.so.1.3 feat_set W: flite undefined-non-weak-symbol /usr/lib/libflite_cmu_time_awb.so.1.3 usenglish_init .......... (too many, cannot write all of them) -------------------------------------------------------------------------------- You can check these by 'ldd -r /usr/lib/libflite.so.1.3', for example. If these libraries are used only by binaries in flite rpm, this may be ignored for a moment (some reviewers disagree). However, it seems that you want to provide -devel package, for which case, this problem should be fixed because undefined non-weak symbols disables correct linkage. 3. I suggest that when applying patches the suffixes should be changed for different patches. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review