Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 Dave Malcolm <dmalcolm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmalcolm@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dmalcolm@xxxxxxxxxx --- Comment #2 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2010-05-26 17:32:03 EDT --- Broadly-speaking, this looks like a sane packaging of pyjamas. A few nits: > # NOTE: we only byte-compile the library files. > # This is because: > # DO NOT install the pyjamas libraries into /usr/share/python-support, > # /usr/lib/python2.N/site-packages or ANY location where the "standard" > # python interpreter could possibly pick them up. The pyjamas libraries > # have nothing to do with python libraries when used by the compiler, > # and contain replacements for sys.py, time.py and other modules that > # are critical to pyjamas. It goes without saying that if you overwrite > # the standard python modules with the pyjamas equivalents, you will run into > # massive problems. Don't do it. I found the above specfile comment a little unclear; it looks like it was copied from upstream instructions, but it immediately raises questions: do the pyjamas libraries get installed, and if so where? %description desktop Typo: s/he /The / In the %files for the core package, you use: %{python_sitelib}/* Is it possible to be a bit more explicit on this line? Especially with the comment above, you've got me feeling paranoid about exactly what the payload of the package is. Pyjamas provides reimplementations of various parts of the standard library, in a mix of pure python and JS (see pyjs/src/pyjs/lib/) "License" may be more complex that the specfile indicates; there's lots of info in the "copyright" file in the tarball, with a variety of licenses. builder/boilerplate/pygwt.js has the comment "// this is almost directly taken from Google's GWT which is now open source": may want to clarify that this is properly licensed. Somewhat ironically, contrib/copyright_check.py ("debian copyright file checker") doesn't seem to have a license (still reading through the tarball) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review