Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582106 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-26 14:45:37 EDT --- >From next time please change the release number every time you modify your spec file (when version number doesn't change) to avoid confusion, even during under review process. Now for new -1: ! Comments - It is better that you remove comments which are no longer needed for readability. ! %clean section - If you want to import this package into F-12, %clean section is still needed. * Duplicate files entry: --------------------------------------------------------- 145 warning: File listed twice: /usr/share/pixmaps/lifeograph 146 warning: File listed twice: /usr/share/pixmaps/lifeograph.png 147 warning: File listed twice: /usr/share/pixmaps/lifeograph/backgrounds 148 warning: File listed twice: /usr/share/pixmaps/lifeograph/backgrounds/bg.png 149 warning: File listed twice: /usr/share/pixmaps/lifeograph/backgrounds/bg.png --------------------------------------------------------- - Note that the %files entry --------------------------------------------------------- %files %{_datadir}/pixmaps/lifeograph --------------------------------------------------------- contains the directory %_datadir/pixmaps/lifeograph and all files/directories/etc under this directory. Also this package should not own the directory %{_datadir}/pixmaps itself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review