Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594943 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |martin.gieseking@xxxxxx Flag| |fedora-review? --- Comment #20 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-05-26 13:56:45 EDT --- Hi Robin, thanks for clarifying the patch issue. Let's hope the library maintainer will accept it. Here's the formal review of libnoise. The spec file is almost fine. Just one minor thing: Please move "rm -rf $RPM_BUILD_ROOT" to the top of the %install section as requested by the EPEL (and previous Fedora) guidelines. $ rpmlint /var/lib/mock/fedora-13-x86_64/result/libnoise*.rpm libnoise.src: W: spelling-error %description -l en_US multifractal -> multifaceted, multiracial, multifarious libnoise.x86_64: W: spelling-error %description -l en_US multifractal -> multifaceted, multiracial, multifarious libnoise-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 3 warnings. The above warnings can be safely ignored. --------------------------------- keys used in following checklist: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - LGPLv2+ according to source file headers [+] MUST: The License field must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. - COPYING.txt added in %doc [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum libnoisesrc-1.0.0.zip* fc0d9b4f6477397568c3a9d5294b3b8c libnoisesrc-1.0.0.zip fc0d9b4f6477397568c3a9d5294b3b8c libnoisesrc-1.0.0.zip.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - builds in koji for F-12, F-13, and rawhide [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. - no locales [+] MUST: Packages storing shared library files must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [+] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. - no static libs packaged [+] MUST: Library files that end in .so (without suffix) must go in a -devel package. [+] MUST: devel packages must require the base package using a fully versioned dependency. [+] MUST: Packages must NOT contain any .la libtool archives. - .la files removed [.] MUST: Packages containing GUI applications must include a %{name}.desktop file. - no GUI [+] MUST: Packages must not own files or directories already owned by other packages. [X] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}. - Please move the rm statement to the top of the %install section [+] MUST: All filenames in rpm packages must be valid UTF-8. [+] SHOULD: The reviewer should test that the package builds in mock. - builds in mock [+] SHOULD: The reviewer should test that the package functions as described. - a small test program calling a library funtion compiled, linked, and worked properly on F-13. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [+] SHOULD: Subpackages other than devel should require the base package. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review