Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591982 --- Comment #3 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-05-25 14:32:12 EDT --- Thanks for your comments, Martin. (In reply to comment #2) > - the package license seems to be GPLv2+, not GPLv3+ > > - file COPYING is missing in %doc Both fixed. SRPM: http://cwickert.fedorapeople.org/review/batti-0.3.7-2.fc14.src.rpm SPEC: http://cwickert.fedorapeople.org/review/batti.spec > - if I understand the guidelines correctly, BR: python-devel is not sufficient > any longer, but an explicitly given Python version number is required > (https://fedoraproject.org/wiki/Packaging:Python#BuildRequires) AFAIK there is no need to select a python version. batti should build both with python 2 and 3 so I prefer to make the switch when Fedora finally switches. This is easier with a simple "python-devel". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review