Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561456 Stanislav Ochotnicky <sochotni@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-05-25 07:24:31 EDT --- (In reply to comment #4) > > While spec file explains how to create Source0 it fails to provide > > reliable way to verify no changes happened between Source0 was taken > > and building of RPM. You need to specify git hash (part of it at > > least) of commit that should be checked out after cloning. Once some > > version is released by developer, it would be ideal if git tag hash was > > used instead. > > > > FIXED. It seems the upstream author released a project tarball not long after I > uploaded this package, so now I'm just using that. > > > > This also applies to naming of package. This is most certainly a > > pre-relase so naming convetions are these: > > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#PreReleasePackages > > > > This is not a pre-release. This is the 0.1 release. According to that wiki link > a prerelease would be something like 0.2alpha or what not. What I meant was that your original spec file had instructions on how to create a tar file with simple git clone && tar cjf . This is all nice, but git is a moving target. It could be different every time you do a new clone. By changing to use tarball created by developer we can now say this is release 0.1. But there was no release 0.1 before, so your spec file was pre-release. There was a tag for version 0.1, but your spec file didn't use it. Anyway...this has been fixed now so let's move on :-) Spelling warnings were not just for srpm but for rpm packages as well. If you notice there are jnr-x86asm.noarch and jnr-x86asm-javadoc.noarch rpmlint messages. But those were false positives anyway just like you said. With changes you made this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review