Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594844 Ville Skyttä <ville.skytta@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ville.skytta@xxxxxx Flag| |fedora-review? --- Comment #3 from Ville Skyttä <ville.skytta@xxxxxx> 2010-05-24 14:37:10 EDT --- 1) If no previous version of -libs is installed (for example in a clean mock build), the test suite throws errors but doesn't fail the build: make: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test' make check-TESTS make[1]: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test' /builddir/build/BUILD/iec16022-0.2.4/.libs/lt-iec16022: error while loading shared libraries: libiec16022.so.0: cannot open shared object file: No such file or directory [...] diff: testsuite-test.text: No such file or directory Text test FAILED diff: testsuite-test.eps: No such file or directory EPS test FAILED diff: testsuite-test.png: No such file or directory PNG test FAILED diff: testsuite-test.bin: No such file or directory Bin test FAILED diff: testsuite-test.hex: No such file or directory Hex test FAILED rm: cannot remove `testsuite-test.*': No such file or directory PASS: ./testsuite.sh ============= 1 test passed ============= Some LD_LIBRARY_PATH settings should be added to make the test suite do the right thing (use the just built libraries, this should be reported upstream), for example this at start of %check: export LD_LIBRARY_PATH=$RPM_BUILD_ROOT%{_libdir} And patching of upstream build process/test scripts is needed; if tests fail, the test suite and build should fail too. 2) (Cosmetic) --disable-dependency-tracking is the default nowadays, it can be dropped from %configure arguments. 3) Would not hurt to make the dependency on -libs in -devel arch qualified, ditto perhaps add one from main package to -libs: Requires: %{name}-libs%{?_isa} = %{version}-%{release} http://fedoraproject.org/wiki/PackagingDrafts/ArchSpecificRequires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review