Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=586433 Chen Lei <supercyper1@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper1@xxxxxxxxx --- Comment #9 from Chen Lei <supercyper1@xxxxxxxxx> 2010-05-24 11:07:27 EDT --- Some more suggestions: The tarball bundles two seperate projects - xnoise and xnoise-plugins-core. It may not be appropriate. It's seems 0.1.2 is still a prerelease, you should modify you release field to match naming guideline. See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages I highly suggest you to preprocess vala code to pure C in spec and not ship preprocessed code in you source tarball. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review