Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594943 --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-05-24 02:54:22 EDT --- Hi Robin, I just had a closer look at the package, and found a couple of further things to be addressed: - The library is licensed under LGPLv2+, not GPLv2+. Please update the License field accordingly. - Source0 should be updated according to https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net - I suggest to use the same suffix (.patch) for all patches. - The doxygen documentation is indeed quite extensive. It's a good idea to put it in a -doc subpackage. - Remove the Makefile from %{_includedir}/noise/ - %{_includedir}/* is a bit too generic. Please change it to %{_includedir}/noise/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review