[Bug 595011] Review Request: <sshdfilter> <Filter for SSH ports>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595011

--- Comment #6 from Rafael Aquini <aquini@xxxxxxxxx> 2010-05-23 22:15:53 EDT ---
David,

Since a picture is a lot more valuable than a thousand words, take this comment
as an example, please.

Spec URL: http://aquini.tchesoft.com/RPMS/sshdfilter/sshdfilter.spec
SRPM URL:
http://aquini.tchesoft.com/RPMS/sshdfilter/sshdfilter-1.5.5-2.fc12.src.rpm

MD5 sum:
8f0422d6150841ba08017faa3dcc1a52  sshdfilter.spec
ea2d0b58375debb7d337f2930d33dc2d  sshdfilter-1.5.5-2.fc12.src.rpm

As you will see, I stripped off from this Spec your former %post and %postun
sections. Well, in plain words there is no simple and safe way to have such
modifications done in those config files. What I'm trying to mean is there is
no simple way to predict how those files will be found when an user tries to
install, update or remove sshdfilter package. Even if we could find out how to
get this task accomplished on its whole complexity, it will represent a lot of
(complex) work to those two RPM sections. And for the worst, your package would
be messing with other RPMs belongings (that's not so good...). 
So, said that my suggestion is: do not change those files and instruct users,
through documentation, to do just after sshdfilter installation instead.

Of course all of that I've presented are just suggestions that you can consider
or not.

Best regards.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]