Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587438 --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-23 15:14:46 EDT --- Created an attachment (id=415990) --> (https://bugzilla.redhat.com/attachment.cgi?id=415990) patch to fix failed test For -2: * Virtual provides name for BR - As rubygem(foo) virtual provides names are provided, please use this style for rubygem related packaged as BR, like "BuildRequires: rubygem(rake)". ref: (although the following is for perl:) https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides * Directory ownership issue - The directory %geminstdir itself is not owned by any packages. * Documents - Usually I also mark "Rakefile" "setup.rb" as %doc (because these are like "makefile"s for autotool system) * Test failure - the attached patch fixes test failure ! Note - Currently "rake test" fails in some weird ways like: ----------------------------------------------------------------- 1) Error: test_trap_v1(TestManager): NoMethodError: undefined method `new' for Integer:Class ./test/test_manager.rb:135:in `test_trap_v1' 2) Error: test_integer_comparable(TestVarBind): NoMethodError: undefined method `new' for Integer:Class ./test/test_varbind.rb:212:in `test_integer_comparable' ----------------------------------------------------------------- I guess some namespaces or so are conflicting when multiple files are subsequently loaded by rake/rake_test_loader.rb, however I have not examined this yet. ( As with the attached patch, "for f in test/*.rb ; do .... ; done" test way succeeds, so currently I don't think this as a blocker ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review