Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593069 --- Comment #6 from Tim Lauridsen <tim.lauridsen@xxxxxxxxxxxxxx> 2010-05-23 02:41:12 EDT --- [*] : MUST: rpmlint must be run on every package. The output should be posted in the review. [*] : MUST: The package must be named according to the Package Naming Guidelines . [*] : MUST: The spec file name must match the base package %{name} [*] : MUST: The package must meet the Packaging Guidelines . [*] : MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [*] : MUST: The License field in the package spec file must match the actual license. [*] : MUST: license(s) in %doc. [*] : MUST: The spec file must be written in American English. [*] : MUST: The spec file for the package MUST be legible. [6] [*] : MUST: The sources used to build the package must match the upstream source - SVN checkout so not possible make MD5SUM of upstream tarball. [*] : MUST: Package compile on all supported archs. [*] : MUST: All build dependencies must be listed in BuildRequires [*] : MUST: No locales. [*] : MUST: No shared lib [*] : MUST: no bundled copies of system libraries. [*] : MUST: package is not relocatable. [*] : MUST: A package must own all directories that it creates. [*] : MUST: No duplicate %files entries [*] : MUST: Permissions is set properly. ( %defattr(...) ) [*] : MUST: Each package must consistently use macros. [*] : MUST: The package must contain code, or permissable content. [*] : MUST: no large documentation files [*] : MUST: %doc files don affect runtime [*] : MUST: no header files [*] : MUST: No Static libraries [*] : MUST: No library files [*] : MUST: No devel package [*] : MUST: NO .la libtool archives. [*] : MUST: not a gui app. [*] : MUST: package dont own files/dirs owned by other packages. [*] : MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [*] : SHOULD: Package include license text. [*] : SHOULD: The reviewer should test that the package builds in mock. - Package builds in koji. [*] : SHOULD: The package should compile and build into binary rpms on all supported architectures. [*] : SHOULD: no scriptlets [*] : SHOULD: no subpackages [*] : SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin [X] : SHOULD: your package should contain man pages for binaries/scripts. - Man pages would be nice, but not a blocker. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review