Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #12 from David Cantrell <dcantrell@xxxxxxxxxx> 2010-05-21 20:47:07 EDT --- (In reply to comment #9) > You are not to disable NetworkManager or even to turn on wicd by default, see > https://fedoraproject.org/wiki/Packaging/SysVInitScript#Why_don.27t_we.... I've removed the line that did the chkconfig on for wicd. > You are already making 3 packages. Why not make a 4th one for the pm-utils > scripts so that all the other stuff can be noarch as it should? > > How about naming the base package wicd-common instead of just wicd? The common > indicated that it's not the full wicd package but just shared files between > other packages. Good idea. I have implemented what I think is a nice way to accomplish this split in the packages. First, I do want to keep a package named 'wicd' because that's what the software is called and I think at least one package should be named wicd. Second, having some noarch packages and some arch packages built from one spec file becomes difficult to manage, so here's how I split things: 1) The 'wicd' package contains the architecture dependent parts of wicd, which is limited to the pm-utils script right now. This could change as wicd gains more functionality. 2) The 'wicd-common' package contains what was in the wicd package: the daemon, command line client, lang files, and docs. 3) The 'wicd' and 'wicd-common' packages require each other, so you will always need to have both installed. If we want to, I could drop the requirement from wicd-common so that people could have wicd-common installed without the arch-dependent wicd package. This effectively splits things in to arch/noarch pieces and keeps a package named 'wicd'. > You should pass more options to configure, at least --distro=redhat. I think > other options like --share or --lib should be passed as well, then somebody can > build the package with rpmbuild --rebuild --define=_datadir /foo/shared. Changed. > Please don't specify the extension of manpages. Imagine we switch from gz to > bz2. Changed. > The files in %{_datadir}/man/nl must be tagged with %lang(nl) Changed. > The package must not own %{_datadir}/icons/hicolor and folders below. It only > should own the icons. For directory ownership you can require > hicolor-icon-theme, but this is not needed as it is already required by gtk2 > (through pygtk2) Changed. > %dir %{_datadir}/wicd/curses > %{_datadir}/wicd/curses/* > is the same as > %{_datadir}/wicd/ > Using %dir here only makes sense if you want to exclude certain files (because > they should go into another package). Changed. > %{_sysconfdir}/xdg/autostart/wicd-tray.desktop is not a config file. Changes > are made in the private ~/.config/autostart namespace. Changed. New spec file and SRPM: http://dcantrel.fedorapeople.org/wicd/wicd.spec http://dcantrel.fedorapeople.org/wicd/wicd-1.7.0-1.fc13.src.rpm Thanks for all the review feedback! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review