Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593839 --- Comment #16 from David Cantrell <dcantrell@xxxxxxxxxx> 2010-05-21 18:54:30 EDT --- I have updated the spec file and SRPM with the changes noted in comments 9 through 15. Here's a summary: 1) Discontinue the use of basic command macros. 2) Creation and inclusion of the examples/ in the %doc list. 3) Change to using the slightly different sed command to remove the #! line. One concern raised is whether or not python-urwid should require python-twisted-core or pygobject2. I cannot tell what the conclusion on that was, so I did not add either. My personal take on it that since the module wraps the import statements in try/except blocks, python-urwid should be fine. If users want the twisted functionality, they can install the python-twisted-core package. If anything dependent on python-urwid requires the twisted usage inside python-urwid, then that package can Require both python-urwid and python-twisted-core. New spec and SRPM: http://dcantrel.fedorapeople.org/python-urwid/python-urwid.spec http://dcantrel.fedorapeople.org/python-urwid/python-urwid-0.9.9.1-1.fc13.src.rpm Thanks for all the review feedback! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review