Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555990 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-21 14:01:20 EDT --- This package seems almost okay. Well, * Documents - I think test/ tasks/ directories should also be marked as %doc. * activerecord dependendency ---------------------------------------------------------------- [tasaka1@localhost ~]$ irb irb(main):001:0> require "rubygems" => true irb(main):002:0> require "acts_as_list" NameError: uninitialized constant ActiveRecord from /usr/lib/ruby/gems/1.8/gems/acts-as-list-0.1.2/lib/acts_as_list.rb:254 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' from (irb):2 from /usr/lib/ruby/site_ruby/1.8/rubygems/exceptions.rb:91 ---------------------------------------------------------------- - I think lib/acts_as_list.rb should explicitly have 'require "active_record"'. How do you think? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review