Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577974 Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mattias.ellert@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2010-05-21 13:26:53 EDT --- Fedora review glite-security-trustmanager 2010-05-21 rpmlint output: $ rpmlint ~/rpmbuild/RPMS/*/glite-security-trustmanager-* ../glite-security-trustmanager-2.5.5-1.fc12.src.rpm glite-security-trustmanager-javadoc.noarch: W: spelling-error Summary(en_US) javadocs -> java docs, java-docs, Javanese glite-security-trustmanager-tomcat5.noarch: W: spelling-error %description -l en_US util -> til, until, u til glite-security-trustmanager-tomcat5.noarch: W: spelling-error %description -l en_US nescesary -> necessary, necessarily, Nescafe glite-security-trustmanager-tomcat5.noarch: W: log-files-without-logrotate /var/log/glite-security-trustmanager glite-security-trustmanager.x86_64: W: spelling-error %description -l en_US util -> til, until, u til glite-security-trustmanager.src: W: spelling-error %description -l en_US util -> til, until, u til glite-security-trustmanager.src:170: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name}/%{name}-%{version}.jar.* glite-security-trustmanager.src: W: invalid-url Source0: glite-security-trustmanager-2.5.5.tar.gz 5 packages and 0 specfiles checked; 0 errors, 8 warnings. The spelling error "nescesary" → "necessary" should be fixed, otherwise OK. + Java package with a single jarfile → package name equals name of jar + Specfile is named after package + License "ASL 2.0" is a Fedora approved license + The license tag in the spec file corresponds to the license of the sources + License file is included in %doc + Specfile is written in legible English + Sources matches upstream + Package compiles successfully (Fedora 13) koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2201657 + BuildRequires are sane + No bundled libraries - Package should own the directory /usr/lib64/gcj/glite-security-trustmanager + No duplicate files ? Permissions are sane and %files has %defattr Marking the gcj aot files with %attr(-,root,root) seems redundant though, since this is covered by the %defattr + Specfile uses macros consistently + %doc is not runtime essential + Package does not own others directories The /etc/grid-security directory is owned by many packages, but there is no "master" package on which all the others depend on, so this is fine ? Do you need vomsjapi in the list of java libraries that get put in the tomcat server lib repository in the %post scriptlet? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review