Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581509 --- Comment #9 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-05-21 03:11:34 EDT --- review: ? - issue + - OK - - NA * - checking + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. at line 102, forgot brackets around buildroot :P + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [Ankur@localhost rpmbuild]$ md5sum SOURCES/yacas-1.2.2.tar.gz 329f149ca3ceb976a7e596b56fc3cba5 SOURCES/yacas-1.2.2.tar.gz [Ankur@localhost rpmbuild]$ md5sum yacas-1.2.2.tar.gz 329f149ca3ceb976a7e596b56fc3cba5 yacas-1.2.2.tar.gz - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. + Headers/static libs in -devel subpackage. + Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. ? -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file - Package compiles and builds on at least one arch. - Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) SHOULD Items: * Should build in mock. * Should build on all supported archs * Should function as described. - Should have sane scriptlets. ? Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version + check for outstanding bugs on package. (For core merge reviews) Issues: 1.I see that miniLZO has been bundled along with yacas. That isn't permitted :( https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries You'll have to take care of that, since it's a library. It should be packaged separately and reviewed. yacas should then mention it as a build requires IMO. 2. The requires on the base package need to be versioned. 3. Short comments on the requires you've added is advised. I'm checking the should items, you should meanwhile correct the above. The bundled lib is a blocker. The package cannot be approved until that is corrected Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review