[Bug 593839] Review Request: python-urwid - Console user interface library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593839

--- Comment #10 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2010-05-21 01:07:40 EDT ---
(In reply to comment #9)

> Packaing tricks has a better command that can remove both /usr/bin/python and
> /usr/bin/env python shebang from *.py files.
> 
> See 
> https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_files    

Well, they are almost the same, so I don't think they are better - I'd rather
say that they are slightly different :)


(In reply to comment #8)

> There is a test_urwid.py script at the top level which performs unit tests on
> the module.  I added a %check section that runs this script.  I left the other
> _test functions and classes in the module code.
> 
> New spec file and SRPM uploaded:
> http://dcantrel.fedorapeople.org/python-urwid/python-urwid.spec
> http://dcantrel.fedorapeople.org/python-urwid/python-urwid-0.9.9.1-1.fc13.src.rpm    

There is one new issue - lack of "BuildRequires: python-twisted-core". I also
suspect, that there is also lack of "Requires: python-twisted-core" - take a
look at the output of 

$ grep twisted urwid/*py

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]