Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #6 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> 2010-05-20 23:22:45 EDT --- You will need to add some scriptlets for the gtk package. %files gtk %{_datadir}/icons/hicolor https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache %post gtk touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun gtk if [ $1 -eq 0 ] ; then touch --no-create %{_datadir}/icons/hicolor &>/dev/null gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans gtk gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : The desktop file also has a depreciated error + desktop-file-validate /home/leigh/rpmbuild/BUILDROOT/wicd-1.7.0-1.fc13.x86_64/usr/share/applications/wicd.desktop /home/leigh/rpmbuild/BUILDROOT/wicd-1.7.0-1.fc13.x86_64/usr/share/applications/wicd.desktop: warning: value "Application;Network;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application" + /usr/lib/rpm/find-lang.sh /home/leigh/rpmbuild/BUILDROOT/wicd-1.7.0-1.fc13.x86_64 wicd Change desktop-file-validate %{buildroot}%{_datadir}/applications/wicd.desktop To desktop-file-install \ --remove-category="Application" \ --delete-original \ --dir=%{buildroot}%{_datadir}/applications \ %{buildroot}/%{_datadir}/applications/wicd.desktop Your spec file doesn't have a buildroot tag https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag rpmlint /wicd-1.7.0-1.fc13.src.rpm wicd.src: W: spelling-error %description -l en_US cli -> cl, clii, clip wicd.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end wicd.src: W: no-buildroot-tag 1 packages and 0 specfiles checked; 0 errors, 3 warnings. I believe you need to add some init scriptlets https://fedoraproject.org/wiki/Packaging/SysVInitScript rpmlint wicd-1.7.0-1.fc13.x86_64.rpm wicd.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/wicd wicd.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/wicd Requires(post): chkconfig Requires(preun): chkconfig # This is for /sbin/service Requires(preun): initscripts ... %post if [ "$1" == "1" ]; then /sbin/chkconfig --add wicd /sbin/chkconfig --level 2345 wicd on fi %preun if [ $1 -eq 0 ]; then /sbin/service wicd stop >/dev/null 2>&1 /sbin/chkconfig --del wicd fi You may need to add this as well, but I'm not familiar with init scripts # This is for /sbin/service Requires(postun): initscripts ... %postun if [ "$1" -ge "1" ] ; then /sbin/service wicd condrestart >/dev/null 2>&1 || : fi You also have a lot of shebangs https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_files wicd.x86_64: E: non-executable-script /usr/lib/python2.6/site-packages/wicd/backend.py 0644L /usr/bin/env wicd.x86_64: E: non-executable-script /usr/lib/python2.6/site-packages/wicd/wnettools.py 0644L /usr/bin/env wicd.x86_64: E: non-executable-script /usr/lib/python2.6/site-packages/wicd/networking.py 0644L /usr/bin/env wicd.x86_64: E: non-executable-script /usr/share/wicd/daemon/wicd-daemon.py 0644L /usr/bin/env wicd.x86_64: E: non-executable-script /usr/lib/python2.6/site-packages/wicd/dbusmanager.py 0644L /usr/bin/env wicd.x86_64: E: non-executable-script /usr/lib/python2.6/site-packages/wicd/configmanager.py 0644L /usr/bin/env wicd.x86_64: E: non-executable-script /usr/share/wicd/backends/be-external.py 0644L /usr/bin/env wicd.x86_64: E: non-executable-script /usr/share/wicd/backends/be-ioctl.py 0644L /usr/bin/env wicd.x86_64: E: non-executable-script /usr/lib/python2.6/site-packages/wicd/logfile.py 0644L /usr/bin/python wicd.x86_64: E: wrong-script-end-of-line-encoding /usr/lib/python2.6/site-packages/wicd/logfile.py wicd.x86_64: E: executable-marked-as-config-file /etc/acpi/resume.d/80-wicd-connect.sh wicd.x86_64: E: non-executable-script /usr/lib/python2.6/site-packages/wicd/translations.py 0644L /usr/bin/env They can be fixed by adding this to the spec file for lib in %{buildroot}%{python_sitelib}/wicd/*.py; do sed '/\/usr\/bin\/env/d' $lib > $lib.new && touch -r $lib $lib.new && mv $lib.new $lib done The debug package is empty (no surprise there) rpmlint '/home/leigh/Desktop/wicd-debuginfo-1.7.0-1.fc13.x86_64.rpm' wicd-debuginfo.x86_64: E: empty-debuginfo-package 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Add this to disable the debug package %define debug_package %{nil} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review