Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587198 --- Comment #8 from Markus Mayer <LotharLutz@xxxxxx> 2010-05-20 12:42:28 EDT --- Just a few things for now. According to https://fedoraproject.org/wiki/Packaging:Java At a minimum, Java packages MUST: BuildRequires: java-devel [>= specific_version] BuildRequires: jpackage-utils Requires: java >= specific_version Requires: jpackage-utils Group for javadoc should be "Development/Documentation" Think about adding "Requires: Requires: %{name}-%{version}-%{release} " to javadoc subpackage. SOURCE0 is not a vaild URL. Try using: "http://www.jgraph.com/downloads/jgraphx/archive/%{name}-%(echo %{version} |sed 's/\./_/g').zip" Your BuildRoot seams a little odd. Think about using "%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)" instead. "find -name '*.jar' -delete" and "rm -rf docs/api" should be moved to "%prep". It is also a good idea to add "find -name '*.class' -delete" too. I will continue reviewing after these things have been fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review