Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578269 --- Comment #14 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-19 14:31:29 EDT --- Well, for now assuming "GNU copyleft = GPL+", * License - For this package the license tag should be "GPLv2+". * %{version} in SourceURL - It is recommended that you use %{version} tag in SourceURL: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D ? About Patch0 - By the way this 20K xgospel-1.12d-friend.patch written by yourself or you've taken from somewhere? Also it is recommended to write some notes about what is this patch for: https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment * BuildRoot - BuildRoot is no longer needed on Fedora (although rpmlint may complain if you remove this) ! Note: If you want to import this package also into EPEL, BuildRoot is still needed. * Configure option - build.log shows: ---------------------------------------------------------- 99 checking for -lICE... no ---------------------------------------------------------- However as you have "BR: libICE-devel", this shows something is wrong (actually configure is broken at least for this part) * Parallel make - Support parallel make if possible. If parallel make fails, please write a note in the spec file about it: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make * compiler warning: - Well, usually I don't warn about compiler warning during review process, however ----------------------------------------------------------- 441 In file included from /usr/include/string.h:642, 442 from /usr/include/X11/Intrinsic.h:64, 443 from games.c:14: 444 In function 'memset', 445 inlined from 'InitHash' at games.c:185: 446 /usr/include/bits/string3.h:83: warning: call to '__warn_memset_zero_len' declared with attribute warning: memset used with constant zero length parameter; this could be due to transposed parameters 447 In function 'memset', 448 inlined from 'InitHash' at games.c:186: 449 /usr/include/bits/string3.h:83: warning: call to '__warn_memset_zero_len' declared with attribute warning: memset used with constant zero length parameter; this could be due to transposed parameters ----------------------------------------------------------- - These are arguably bugs, please fix these. * Icon entry in desktop file - It is recommended that extension (.xpm) is removed: https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files * Categories for Desktop files - Catogories "X-Fedora", "Application" are no longer used and should be removed. * Document files - Usually "INSTALL" file is for people trying to build a software by themselves and not needed for people trying to install one using rpm. By the way it is recommended that you upload your srpm to some place from which we can directly download it by "wget -N", for example. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review