Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libopm - Blitzed open proxy monitor library Alias: libopm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212894 ------- Additional Comments From redhat-bugzilla@xxxxxxxxxxxx 2006-10-31 08:10 EST ------- > - Source0 should list the full download URL and use %{name} > - You need to mention in a comment how to download the source if there is not a direct URL Fixed; you're right of course. > - make should use $RPM_OPT_FLAGS Hum? gcc -DHAVE_CONFIG_H -I. -I. -I. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 - mtune=generic -fasynchronous-unwind-tables -c config.c -MT config.lo -MD -MP -MF .deps/config.TPlo -fPIC -DPIC -o .libs/config.lo -- IMHO $RPM_OPT_FLAGS seems to be used. What should be wrong here? > - use %defattr(-,root,root,-) I'm using %defattr(-,root,root) which fits and does the same. I wasn't able to find sth else e.g. at http://fedoraproject.org/wiki/Packaging/ReviewGuidelines (which says, that %defattr(...) must be used). > - I think the group should be Development/Libraries for the main package as > well, although I cannot find anything which specifies how the groups are > defined Why? libtiff, libjpeg, libidn, libselinux, libesmtp, librsync are using the same like mine. Why should System Environment/Libraries be wrong? It decribes simply perfect the main package of libopm - IMHO. > - You should use --disable-static on the %configure Hum? MUST: Header files or static libraries must be in a -devel package. This is what I'm following (http://fedoraproject.org/wiki/Packaging/ReviewGuidelines). > - I think the version number should be done like so: Looks whether you're right. But I found AC_INIT() in configure.in, which tells version 0.1, So it would be the following, right? IMO it must be a post release of 0.1, because 0.1 was always set when browsing through viewcvs of Blitzed. Version: 0.1 Release: 2.20050731cvs%{dist} I'll push a new build when all things are clarified. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review