Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560176 --- Comment #11 from David Cantrell <dcantrell@xxxxxxxxxx> 2010-05-19 10:19:00 EDT --- New SRPM and spec posted: http://dcantrel.fedorapeople.org/clpbar/clpbar.spec http://dcantrel.fedorapeople.org/clpbar/clpbar-1.10.9-2.fc12.src.rpm Issues addressed: 1) The debuginfo package contains debug information now (removed the LDFLAGS override). 2) The Makefile does not override the RPM opt flags. Answers to other questions or statements made: 1) "The upstream for clpbar seems long dead, the latest version came out 3 years ago and the CVS is empty." This is true. I'm not sure the author ever used the SourceForge CVS service. He may just have uploaded tarballs for release. I emailed him for clarification. It is also true that there have been no releases in 3 years, but that does not mean the project is dead or not useful. procps often goes years between actual releases. 2) "Have you ever send bar-1.10.9-clpbar.patch to upstream, this patch is not a fedora specific patch." I have not and would prefer not to. The patch itself just changes the source to install the application as 'clpbar' instead of 'bar' (and man page as 'clpbar.1' instead of 'bar.1'), so in that respect I would consider it Fedora-specific. However, he does carry Debian-specific packaging information in the upstream source, so I will ask if he is interested in our packaging changes. 2) "Also, source code does not include license blocks on top and COPYING file mentions GPLv2 license. May you confirm with upstream about license bits and request them to include it into code if possible ?" The COPYING file is actually the LGPL version 2, not the GPL version 2. It is true that his source files do not have any license boilerplate. I asked the author for clarification on the issue. My reason for considering the entire package LGPLv2 is the fact that the COPYING file is included in the source and the debian/copyright file in the source tree confirms this. The package is or was included with Debian at some point, but I do not know how to check if it is still part of Debian or not. Thanks for the review feedback. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review