Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593274 --- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-19 04:14:30 EDT --- Well, * Documents - It is better that test/ directory is marked as %doc ( I usually also mark Rakefile as %doc ) * Macros in %changelog - Use %% instead of % to avoid unexpanded macro expansion in %changelog. * Requires - lib/will_paginate.rb contains: ------------------------------------------------------------ 1 require 'active_support' 2 require 'will_paginate/core_ext' ------------------------------------------------------------ So at least this should have "Requires: rubygem(activesupport)". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review