Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592670 --- Comment #14 from Chen Lei <supercyper1@xxxxxxxxx> 2010-05-18 15:08:45 EDT --- (In reply to comment #13) > > o ship .c and .h file in devel package for use in embedded mode? > Those were shipped in the first version, in a -devel rpm. Chen has pointed it > as unnecessary and I stripped it off from Spec. I can reinclude the %package > section and ship those files again. You can split out libmongoose and libmongoose-devel as subpackages or simply drop those files. Include source files in rpm is not a right way. > > o mongoose seems to do some funky things with SSL. There are no req. > > on ssl libs, but package seems to have SSL support. > In SSL mode, mongoose tries to load libssl.so on demand -- pretty much like > apache does with its modules. It was my fault not include the libssl-devel req. > My question, now, is that: Should I include this -devel req in the ordinary rpm > or should I ship it as another rpm (like -ssl), just to fulfill this req, that > users must install if they want SSL support? If the shlib is dlopened, you should not add it as a dependency. > (In reply to comment #12) > Chen, as it seems that you ended up agreeing with Terje and Ralf, I will adopt > your last suggestion and just use macros from now on (until we haven't another > guidance).Please do not take it as personal, I just really think that macros > are useful and cleaner than simple cmds. Few sponsors like this style. See http://lists.fedoraproject.org/pipermail/devel/2010-March/133466.html Also few crital packages in fedora use those macros. http://cvs.fedoraproject.org/viewvc/rpms/kernel/devel/kernel.spec?view=markup http://cvs.fedoraproject.org/viewvc/rpms/glibc/devel/glibc.spec?view=markup http://cvs.fedoraproject.org/viewvc/rpms/gtk2/devel/gtk2.spec?revision=1.430&view=markup I agree with Ralf that no guideline against using of those macros, but I still suggest you not to use them. Actually, those macros are not documented in fedora guideline. http://fedoraproject.org/wiki/Packaging/RPMMacros -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review