Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591737 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pingou@xxxxxxxxxxxx --- Comment #1 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2010-05-18 03:57:58 EDT --- I would change the "uarray" to "micro-array" in the description for a better understanding. * Latest version packaged 5b5eb004ba4c3ce7f01910d5bbb83b8dc3648c3c ROC_1.24.0.tar.gz 5b5eb004ba4c3ce7f01910d5bbb83b8dc3648c3c /home/pierrey/rpmbuild/SOURCES/ROC_1.24.0.tar.gz * sha1sum are equals * All required Requires are present * All required BuildRequires are present * There is 1 %dir %dir is OK * There is 4 %doc ? More element than expected in %doc COPYING This is fine * The rpm installed in _libdir * The rpm seems to have the required element in %install * The rpm uses %{_libdir} and is arch rpmbuild -ba /home/pierrey/rpmbuild/SPECS/R-ROC.spec > R-ROC.spec-build.log 2>&1 * Build properly under 2.6.33.2-57.fc13.x86_64 * rpmlint: R-ROC.src: W: spelling-error %description -l en_US uarray -> array, u array, hurray R-ROC.x86_64: W: spelling-error %description -l en_US uarray -> array, u array, hurray 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Scratch build on koji for target f14 * Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2193549 0 free 0 open 3 done 0 failed 2193549 build (dist-f14, R-ROC-1.24.0-1.fc12.src.rpm) completed successfully * Build is fine * rpmlint's warnings are safe to ignore * %check is present * All -1 check pass successfully (one gives a NOTE, but that's not a blocker) ! License in the DESCRIPTION says LGPLv2+ while the license in COPYING says GPLv2 If you can solve the license question I will approve the package. You might want to ask upstream for the reason of the presence of the file "ROC.hyndman.R" which contains only commented code. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review