Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591812 --- Comment #1 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-05-17 22:28:04 EDT --- The licensing here is a little confused, as perlbrew contains HTTP::Lite... or did? Makefile.PL says "same as Perl", as does the Changelog entries; LICENSE in the root says "MIT", as does lib/App/perlbrew.pm. If it actually includes HTTP::Lite, then it will have to be Perl (or GPL+ at least). If not, then it can be MIT. Everything else here looks good; I hate to say it, but I think we need to get some sort of clarification from the author; the statement of license in perlbrew.pm controls here. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2184763 Spec looks sane, clean and consistent; make test passes cleanly. Source tarballs match upstream (sha1sum): aef837763f49c7c8f4bca88a1878669aa734684f App-perlbrew-0.06.tar.gz aef837763f49c7c8f4bca88a1878669aa734684f App-perlbrew-0.06.tar.gz.srpm Final provides / requires are sane: ====> rpmlint perlbrew.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. ======> perlbrew-0.06-1.fc14.noarch.rpm <====== ====> rpmlint perlbrew.noarch: W: spelling-error Summary(en_US) perl -> Perl, peel, perk perlbrew.noarch: W: spelling-error %description -l en_US perl -> Perl, peel, perk perlbrew.noarch: W: spelling-error %description -l en_US bashrc -> Basho, bashful, bashing perlbrew.noarch: W: spelling-error %description -l en_US cshrc -> cashier, crush, crash perlbrew.noarch: W: spelling-error %description -l en_US sudo -> suds, ludo, sumo perlbrew.noarch: W: spelling-error %description -l en_US cpan -> can, pan, span 1 packages and 0 specfiles checked; 0 errors, 6 warnings. ====> provides perl(App::perlbrew) = 0.06 perl-App-perlbrew = 0.06-1.fc14 perlbrew = 0.06-1.fc14 ====> requires /usr/bin/perl perl >= 1:5.8.0 perl(:MODULE_COMPAT_5.10.1) perl(App::perlbrew) perl(Getopt::Long) perl(HTTP::Lite) >= 2.2 perl(Pod::Usage) perl(strict) ====> obsoletes ====> conflicts ======> perlbrew-0.06-1.fc14.src.rpm <====== ====> rpmlint perlbrew.src: W: spelling-error Summary(en_US) perl -> Perl, peel, perk perlbrew.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk perlbrew.src: W: spelling-error %description -l en_US bashrc -> Basho, bashful, bashing perlbrew.src: W: spelling-error %description -l en_US cshrc -> cashier, crush, crash perlbrew.src: W: spelling-error %description -l en_US sudo -> suds, ludo, sumo perlbrew.src: W: spelling-error %description -l en_US cpan -> can, pan, span 1 packages and 0 specfiles checked; 0 errors, 6 warnings. ====> provides ====> requires perl >= 1:5.8.0 perl(ExtUtils::MakeMaker) perl(HTTP::Lite) >= 2.2 perl(Test::More) ====> obsoletes ====> conflicts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review