Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: freefont - Free UCS Outline Fonts https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212079 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx ------- Additional Comments From panemade@xxxxxxxxx 2006-10-31 00:31 EST ------- I may officially review this package but still there are some errors to remove I did mock build for i386 rawhide and found that it built package successfully but rpmlint is not silent on SRPM W: freefont unversioned-explicit-obsoletes freefont-ttf The specfile contains an unversioned Obsoletes: token, which will match all older, equal and newer versions of the obsoleted thing. This may cause update problems, restrict future package/provides naming, and may match something it was originally not inteded to match -- make the Obsoletes versioned if possible. ===> use version number with package name W: freefont unversioned-explicit-provides freefont-ttf The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. ===> use version number with package name W: freefont setup-not-quiet You should use -q to have a quiet extraction of the source tarball, as this generate useless lines of log ( for buildbot, for example ) ===> use setup -q not setup W: freefont macro-in-%changelog fontdir Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. ===> As suggested no problem to use macros in Chnagelog but you must use % before macroname. W: freefont mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. ==>see the line 1 and 10 as suggested and remove tab replacing with spaces rpmlint on binary built noarch package is silent -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review