Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590777 Johan Cwiklinski <johan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Johan Cwiklinski <johan@xxxxxxxx> 2010-05-15 05:40:01 EDT --- REVIEW: + rpmlint is clean php-domxml-php4-php5.src: I: checking => (false spelling-error from french removed and ignored) php-domxml-php4-php5.src: I: checking-url http://alexandre.alapetite.fr/doc-alex/domxml-php4-php5 (timeout 10 seconds) php-domxml-php4-php5.src: W: invalid-url Source0: domxml-php4-php5-1.21.1.tar.gz php-domxml-php4-php5.noarch: I: checking => (false spelling-error from french removed and ignored) php-domxml-php4-php5.noarch: I: checking-url http://alexandre.alapetite.fr/doc-alex/domxml-php4-php5 (timeout 10 seconds) php-domxml-php4-php5.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 12 warnings. + package is named according to the Package Naming Guidelines . + spec file name ok + The package meet the Packaging Guidelines and PHP Guidelines + license ok (LGPLv3) and match upstream + license provided + spec file is legible + sources match upstream a735ed6005551a49477b634004ca2c76 domxml-php4-to-php5.php + source URL not ok, but explained in the specfile + build on F13 x86_64 (php 5.3.3dev) + BuildRequires + no locale + no shared library (extension are not lib.) + no system library + own all directories that it creates + not list a file more than once in the spec + Permissions on files are set properly. + %clean ok + consistently use macro + contain code + no doc, no sub package + no -devel + no -static + no .pc + no .la + not own files or directories already owned by other packages + %install start with rm -rf $RPM_BUILD_ROOT + all files are UTF-8 + provides php-domxml-php4-php5 = 1.21.1-1.fc13 + requires php-xml >= 5.1 ***** APPROVED ***** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review