Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591222 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #3 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-05-14 17:45:42 EDT --- (In reply to comment #2) > > Some pedantic comments: > > Yeah, some were too pedantic for me. The others have been fixed in: It would be nice to know which one, this way it's double work... (In reply to comment #1) > Some pedantic comments: > o changelog needs updating >From rpmlint: gtk3.x86_64: W: incoherent-version-in-changelog 2.9.0.0-2 ['2.90.0-2.fc13', '2.90.0-2'] > o use %global over %define Done > o %defattr(-, root, root) -> %defattr(-, root, root, -) Done > o I am bit surprised about various hacks, push at least some > of the changes upstream? Indeed. Or is this not (easyly) possible? Some other comments: - rpmlint (just the relevant ones): gtk3.src: W: strange-permission update-gdk-pixbuf-loaders-3.0 0775L gtk3.src: W: strange-permission update-gtk-immodules-3.0 0775L * Why not 755? gtk3.src:125: W: mixed-use-of-spaces-and-tabs (spaces: line 125, tab: line 125) gtk3.src: W: invalid-url Source0: http://download.gnome.org/sources/gtk+/3.0/gtk+-2.90.0.tar.bz2 HTTP Error 404: Not Found * Will there be a source online? I currently get only 404s. gtk3.x86_64: W: incoherent-version-in-changelog 2.9.0.0-2 ['2.90.0-2.fc13', '2.90.0-2'] gtk3-devel-docs.x86_64: W: file-not-utf8 /usr/share/doc/gtk3-devel-docs-2.90.0/examples/calendar/calendar.c - Could you please use INSTALL="install -p" to preserve timestamps? (also when installing the examples) - It's a bit confusing to use $host and %{_host}, almost impossible to verify as a reviewer... Could you explain them a bit? The rest looks a bit hacky and it would be *nice* to get that parts upstream, but I don't see them as blocker... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review