Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588194 --- Comment #5 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-05-14 16:16:17 EDT --- review + OK - NA ? ISSUE + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [Ankur@localhost SPECS]$ md5sum quickly_0.4.2.orig.tar.gz ../SOURCES/quickly_0.4.2.orig.tar.gz bcb01f8f70d6f082595a05aa089cc168 quickly_0.4.2.orig.tar.gz bcb01f8f70d6f082595a05aa089cc168 ../SOURCES/quickly_0.4.2.orig.tar.gz - Package needs ExcludeArch + BuildRequires correct Please recheck this + Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. ? Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file ? Package compiles and builds on at least one arch. FAILS for rawhide? http://koji.fedoraproject.org/koji/taskinfo?taskID=2188701 it looks like its to do with the version of distutils? please check this. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) will check once build successfully. SHOULD Items: ? Should build in mock. failed koji ? Should build on all supported archs ? Should function as described. not checked yet - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag - Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1.doc files should include the NEWS etc too , please add them 2. fails to build, please build in mock and recheck Please look into the issues, ill continue the review once these are cleared. Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review