Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565251 --- Comment #6 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-05-14 15:36:07 EDT --- Review: + - OK - - NA ? - ISSUE +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. ? License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [Ankur@localhost SPECS]$ md5sum coan-4.1.tar.gz 33ccc73af33c4162ecb55ab1816cd2ae coan-4.1.tar.gz [Ankur@localhost SPECS]$ md5sum ../SOURCES/coan-4.1.tar.gz 33ccc73af33c4162ecb55ab1816cd2ae ../SOURCES/coan-4.1.tar.gz - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. ? No rpmlint output. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done [Ankur@localhost x86_64]$ for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done coan-4.1-1.fc13.x86_64.rpm coan = 4.1-1.fc13 coan(x86-64) = 4.1-1.fc13 .. coan-debuginfo-4.1-1.fc13.x86_64.rpm coan-debuginfo = 4.1-1.fc13 coan-debuginfo(x86-64) = 4.1-1.fc13 .. SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. not checked yet - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1.rpmlint output [Ankur@localhost SPECS]$ rpmlint coan.spec ../RPMS/x86_64/coan-* ../SRPMS/coan-4.1-1.fc13.src.rpm coan.x86_64: W: spelling-error Summary(en_US) commandline -> command line, command-line, commandment coan.x86_64: W: spelling-error Summary(en_US) preprocessor -> processor, teleprocessing, processional coan.x86_64: W: spelling-error %description -l en_US analysing -> analyzing, analysis, analysand coan.x86_64: W: spelling-error %description -l en_US preprocessor -> processor, teleprocessing, processional coan.x86_64: W: spelling-error %description -l en_US unifdef -> uniform, unify, Unicode coan.x86_64: W: spelling-error %description -l en_US sunifdef -> sundries, sunshade, Sunnite coan.x86_64: W: invalid-url URL: http://coan2.sourceforge.net/ <urlopen error [Errno -2] Name or service not known> coan.src: W: spelling-error Summary(en_US) commandline -> command line, command-line, commandment coan.src: W: spelling-error Summary(en_US) preprocessor -> processor, teleprocessing, processional coan.src: W: spelling-error %description -l en_US analysing -> analyzing, analysis, analysand coan.src: W: spelling-error %description -l en_US preprocessor -> processor, teleprocessing, processional coan.src: W: spelling-error %description -l en_US unifdef -> uniform, unify, Unicode coan.src: W: spelling-error %description -l en_US sunifdef -> sundries, sunshade, Sunnite coan.src: W: invalid-url URL: http://coan2.sourceforge.net/ <urlopen error [Errno -2] Name or service not known> 3 packages and 1 specfiles checked; 0 errors, 14 warnings. Minor spelling errors, 2. the src directory has a COPYING file with GPLv3 in it. I don't see why its there. Please just confirm the license of the package. Since the source files say BSD, the file BSD is good. The rest looks good. On its way to approval :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review