Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571416 --- Comment #6 from Karel Volný <kvolny@xxxxxxxxxx> 2010-05-14 05:26:12 EDT --- (In reply to comment #4) > - Could you please use real patches and not write them into the specfile? well, I don't have time to comment case by case right now, but in general, the reason was using some variables available in .spec but not for standalone patch > - There is no %doc. Could you add at least: all COPYING Readme? if I recall correctly, GiGi does not install these files so it'd have to be added manually ... sure, it can be included > (Don't know, when I have the time to review this. > Could take a while, so if someone else stepps it, no problem.) heh :) ... considering the state of the upstream sources, there's no rush ... I just wanted to have some usable package, no need to push it into the distro soon, just that others can find it at least somewhere (In reply to comment #5) > I started working on packaging GiGi myself because my first search didn't turn > up your effort. no problem, as stated above, I haven't too much time to spend on this, feel free to take the best of both efforts and link a new version here > I disagree with the reasoning behind your using 0.6.0 for the base version > number, as the code from the official 0.7.0 tarball also self-identifies as > 0.6.0, and r803 from the subversion repository is definitely more recent than > the 0.7.0 release. that is true but it can cause troubles in dependencies, I think please try to resolve the issue with upstream before using newer version number > I'd suggest building the included GG-Sketch and putting it in a subpackage. feel free to do that :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review