Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591828 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-05-13 12:44:47 EDT --- REVIEW : + rpmlint is ok php-pecl-solr.src: I: checking php-pecl-solr.src: W: spelling-error %description -l fr sérialisable -> sérialisation, sérialisée, sérialise php-pecl-solr.src: I: checking-url http://pecl.php.net/package/solr (timeout 10 seconds) php-pecl-solr.src: I: checking-url http://pecl.php.net/get/solr-0.9.10.tgz (timeout 10 seconds) php-pecl-solr.x86_64: I: checking php-pecl-solr.x86_64: W: spelling-error %description -l en_US serializable -> serialization, serialize, materialization php-pecl-solr.x86_64: W: spelling-error %description -l fr sérialisable -> sérialisation, sérialisée, sérialise php-pecl-solr.x86_64: I: checking-url http://pecl.php.net/package/solr (timeout 10 seconds) php-pecl-solr-debuginfo.x86_64: I: checking php-pecl-solr-debuginfo.x86_64: I: checking-url http://pecl.php.net/package/solr (timeout 10 seconds) php-pecl-solr.spec: I: checking-url http://pecl.php.net/get/solr-0.9.10.tgz (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 83 warnings. => (false spelling-error from french removed and ignored) + package is named according to the Package Naming Guidelines . + spec file name ok + The package meet the Packaging Guidelines and PHP Guidelines + license ok (PHP) and match upstream + license provided + spec file is legible + sources match upstream fe7a9d778c8c3b1fd930de65174c0357ae9e2a23 solr-0.9.10.tgz + source URL ok + build on F13 x86_64 (php 5.3.3dev) + build on mock/koji (F12 ref in previous post) + build on all arch (F-12 + rawhide, i386, x86_64, ppc, ppc64) http://koji.fedoraproject.org/koji/taskinfo?taskID=2185982 2185982 build (dist-rawhide, php-pecl-solr-0.9.10-2.fc8.src.rpm) completed successfully http://koji.fedoraproject.org/koji/taskinfo?taskID=2186012 2186012 build (dist-f12, php-pecl-solr-0.9.10-2.fc8.src.rpm) completed successfully + BuildRequires + no locale + no shared library (extension are not lib.) + no system library + own all directories that it creates + not list a file more than once in the spec + Permissions on files are set properly. + %clean ok + consistently use macro + contain code + small doc, no sub package + doc not required to run + no -devel + no -static + no .pc + no .la + not own files or directories already owned by other packages + %install start with rm -rf $RPM_BUILD_ROOT + all files are UTF-8 + %check ok (only load test) + load in httpd ok + test suite ok (after install) TEST RESULT SUMMARY Number of tests : 21 17 Tests skipped : 4 ( 19.0%) -------- Tests warned : 0 ( 0.0%) ( 0.0%) Tests failed : 0 ( 0.0%) ( 0.0%) Expected fail : 0 ( 0.0%) ( 0.0%) Tests passed : 17 ( 81.0%) (100.0%) + provides config(php-pecl-solr) = 0.9.10-2.fc8 php-pecl(solr) = 0.9.10 php-solr = 0.9.10 solr.so()(64bit) php-pecl-solr = 0.9.10-2.fc8 php-pecl-solr(x86-64) = 0.9.10-2.fc8 + requires /bin/sh /usr/bin/pecl config(php-pecl-solr) = 0.9.10-2.fc8 libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) php(api) = 20090626 php(zend-abi) = 20090626 php-xml >= 5.2.3 + scriptlet ok ***** APPROVED ***** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review