Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openvrml - VRML/X3D runtime library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212715 ------- Additional Comments From braden@xxxxxxxxxxxxx 2006-10-30 03:33 EST ------- (In reply to comment #2) > Basically, the spec is in good shape for an initial submission. Nevertheless, it > needs some work: > > Let's start with what rpmlint has to say: > > 1) > W: openvrml-debuginfo no-version-in-last-changelog > W: openvrml-devel no-version-in-last-changelog > W: openvrml-gl no-version-in-last-changelog > W: openvrml-gl-devel no-version-in-last-changelog > W: openvrml-gtkplug no-version-in-last-changelog > W: openvrml-mozilla-plugin no-version-in-last-changelog > > Please add them. Done, I think. > 2) > W: openvrml-devel no-version-dependency-on openvrml 0.16.1 > openvrml-devel lacks > Requires: openvrml = %{version}-%{release} Check. > 3) > W: openvrml-gl-devel summary-ended-with-dot OpenVRML OpenGL renderer headers and > static library. > W: openvrml-gtkplug summary-ended-with-dot VRML browser GtkPlug component for > embedding in GTK+ applications. > W: openvrml-mozilla-plugin summary-ended-with-dot VRML browser plug-in for > Mozilla-based browsers. > Please remove the '.' at the end of the corresponding Summary: lines. Check. > 4) > E: openvrml-gl library-without-ldconfig-postin /usr/lib/libopenvrml-gl.so.6.0.3 > E: openvrml-gl library-without-ldconfig-postun /usr/lib/libopenvrml-gl.so.6.0.3 > Please add ldconfig calls, analogous to what you apply to the main package to > openvrml-gl Check. > 5) > E: openvrml-gtkplug info-files-without-install-info-postin > /usr/share/info/openvrml-gtkplug.info.gz > E: openvrml-gtkplug info-files-without-install-info-postun > /usr/share/info/openvrml-gtkplug.info.gz > You need to add appropriate calls to /usr/sbin/install-info to openvrml-gtkplug Fixed, I think. > 5) > E: openvrml-gtkplug explicit-lib-dependency libXmu > This requirement is redundant and should be removed (The dependency on libXmu is > already being picked up by rpm). > > In the same boat is this package's "Requires: gtk2". > It also probably is redundant. Okay. > 5) Any particular reason you explicitly "Requires: firefox" at several places? > I thought mozilla-plugins being installed into .../mozilla/plugins were supposed > to be usable by all mozilla-compatible browsers (mozilla, firefox, seamonkey, > etc.), so an explicit "Requires: firefox" seems unnecessarily restrictive to me. For openvrml, it's because libopenvrml links with libmozjs. Hopefully rpm picks this up and this one isn't necessary. For openvrml-mozilla-plugin, it's a holdover since the plug-in used to use XPCOM. It doesn't anymore, so hopefully it's unnecessary, too. > 6) Please "Requires: libGLU-devel" instead of "mesa-libGLU" in *-devel packages. Okay. How come? > 7) Please use "%{version}-%{release}"-style dependencies instead of "%{version}" > dependencies inside of your package. Check. spec: http://endoframe.com/openvrml.spec srpm: http://endoframe.com/openvrml-0.16.1-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review