Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583102 --- Comment #4 from Jean-Francois Saucier <jfsaucier@xxxxxxxxxxxx> 2010-05-13 09:14:36 EDT --- I have a question before posting a new package : > 1. please check the license, the COPYING and source files feature a GPLv1+ Done. You are right, the website mention GPL and I assume GPLv3... It's clearly a GPLv1+ in the COPYING file. > 2. please comment the spec file and add reasons for patching in there too. Done. I added the comments to patches and 1-2 other places in the SPEC file. > 3. why are explicit requires used in the spec? Please add comments justifying them This is my question. I don't see the explicit requires in my SPEC file. I think I don't have any but maybe it's something I don't know. Can you enlight me on this? Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review