Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdeaddons: K Desktop Environment - Plugins https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200236 gauret@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |gauret@xxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From gauret@xxxxxxx 2006-10-30 02:45 EST ------- Package Reviewed : http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/kdeaddons-3.5.5-2.src.rpm) * RPM name is OK * Source kdeaddons-3.5.5.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint of kdeaddons looks OK * rpmlint of kdeaddons-atlantikdesigner looks OK * rpmlint of kdeaddons-xmms looks OK * File list of kdeaddons looks OK * File list of kdeaddons-atlantikdesigner looks OK * File list of kdeaddons-xmms looks OK * Config files of kdeaddons looks OK * Works as expected Needs work: * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines). It's in the COPYING-DOCS file. * Desktop file: the Categories tag should contain Application (wiki: PackagingGuidelines#desktop) (not sure it is really required, but IIRC it's needed to appear in the menu) Notes: * Desktop file: the Categories tag should not contain X-Fedora any more. It's harmless, but remember to remove it in the future. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review