Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591305 --- Comment #3 from Mat Booth <fedora@xxxxxxxxxxxxxx> 2010-05-12 16:36:39 EDT --- (In reply to comment #2) > Whole idea of group rename of all jakarta-commons packages was to avoid having > to have this in apache-commons: > > BuildRequires: jakarta-commons-beanutils >= 1.7 > BuildRequires: jakarta-commons-logging >= 1.1.1 > > and also this > > Requires: jakarta-commons-beanutils >= 1.7 > Requires: jakarta-commons-logging >= 1.1.1 > > I would love to see depends on apache-commons-beanutils/logging. Would it be > possible to wait for beanutils Sure, I can submit the apache-commons-beanutils package for review too, if you'd like? (In reply to comment #2) > (since apache-commons-loggins is already in > rawhide)? Also you have old changelog included, it would probably be better to > start from scratch. > I have nothing against elderly changelogs, and it's not particularly long. I know packages like Kernel and Eclipse trim them periodically because they get absurdly long, but I thought it would be frowned upon to trim it for purely aesthetic reasons... (In reply to comment #2) > Rest is just my curiosity...why have "-Dmaven.compile.target=1.5" ? Were there > problems with building without these defines? Indeed there were, Maven throws a wobbly when using GCJ if you don't set those properties. For some reason 1.2 is the default: Compiling 70 source files to /home/mbooth/rpmbuild/BUILD/commons-digester-1.8.1-src/target/classes source level should be comprised in between '1.3' and '1.6' (or '5', '5.0', ..., '7' or '7.0'): 1.2 [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Compilation failure -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review