Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588474 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #10 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-12 13:18:32 EDT --- Some notes * %ruby_sitelib macro seems to be used nowhere. * When the source code says the license is "the same as Ruby", it means "GPLv2 or Ruby" license tag on Fedora. * Please write the full URL for Source0. * BuildRoot is no longer needed on Fedora - rpmlint may complain, however you can ignore it - If you want to import this package also into EPEL, buildroot is needed on EPEL. * Please properly mark some files and directories as %doc - %geminstdir/[A-Z]* - %geminstdir/install.rb (is this needed?) - %geminstdir/samples/ - %geminstdir/test/ ! Also please consider to split out these document files (and also rdoc and ri files) into -doc subpackge. * Please enable %check section and execute some test program there. ! Note "require 'net/sftp'" line in Rakefile doesn't seem to be needed. * Please fix rpmlint complaints * W: summary-not-capitalized C rubyzip is a ruby module for reading and writing zip files - Repeating "rubyzip is a" in Summary is redundant and should be removed. * Please fix lots of "E: non-standard-executable-perm" or "script-without-shebang" rpmlint complaints. ! For scripts - scripts with shebang should usually be with 0755 permission. - scripts without shebang should usually be with 0644 permission. * Please update %changelog entry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review