Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #10 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-12 12:21:41 EDT --- For -2: * Unused macro / consistent macro usage - %ruby_sitelib macro seems to be used no where. - %geminstdir should also be used also in %check. * The place of documents - I don't see any reason you should move README.markdown or so to under %{_defaultdocdir} * Documents - CONTRIBUTORS, Rakefile files should be marked as %doc. - spec/ test/ directories should also be marked as %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review