Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581280 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2010-05-12 10:33:37 EDT --- A few items before I review this: (There are no erlang packaging guidelines that I'm aware of, so some of what I'm asking might be stuff that belongs in erlang packaging guidelines) * Why are you disabling debuginfo? * With the erlang split, is BuildRequires: erlang really appropriate? What about Requires: erlang? If possible, this should be limited to the required erlang subpackages only. * The license is not BSD, it is MIT. Also, the source code contains no license attribution, you should ask upstream to add it. * It is not necessary to set BuildRoot or delete it during %install anymore, see https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag (EPEL 4 and 5 still require it, but if you're not planning on building for those targets, you can remove these lines) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review