Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561470 --- Comment #25 from Petr Muller <pmuller@xxxxxxxxxx> 2010-05-12 07:51:44 EDT --- Kevin, first of all, thanks for reviewing! New links: http://www.afri.cz/files/beakerlib-1.3-1.fc12.src.rpm http://www.afri.cz/files/beakerlib.spec (In reply to comment #24) > Issues: > > 1. Source doesn't match from upstream: > 5e5ee854add958ce30746a15b9d7e713 beakerlib-1.2.tar.gz > ae18ea068c48e82196ff6cd381e663d9 beakerlib-1.2.tar.gz.orig3 It should match now. The fact that we are also upstream (and we track the specfile in repo, and it then gets in the tarball) makes this a bit complicated to maintain, because the tarball changes everytime I change even the specfile. > > 2. rpmlint says: > > Probibly all these should be chmod 644 or have a #!/bin/sh added if they should > be called stand alone: > > beakerlib.noarch: E: script-without-shebang /usr/share/beakerlib/analyze.sh > beakerlib.noarch: E: script-without-shebang /usr/share/beakerlib/beakerlib.sh > beakerlib.noarch: E: script-without-shebang /usr/share/beakerlib/dictionary.vim > beakerlib.noarch: E: script-without-shebang > /usr/share/beakerlib/infrastructure.sh > beakerlib.noarch: E: script-without-shebang /usr/share/beakerlib/journal.sh > beakerlib.noarch: E: script-without-shebang /usr/share/beakerlib/logging.sh > beakerlib.noarch: E: script-without-shebang /usr/share/beakerlib/performance.sh > beakerlib.noarch: E: script-without-shebang /usr/share/beakerlib/rpms.sh > beakerlib.noarch: E: script-without-shebang /usr/share/beakerlib/testing.sh > beakerlib.noarch: E: script-without-shebang /usr/share/beakerlib/virtualX.sh Not intended for standalone calling, I've fixed the perms. > This can be ignored, but it would be nice to have man pages for these: > > beakerlib.noarch: W: no-manual-page-for-binary beakerlib-deja-summarize > beakerlib.noarch: W: no-manual-page-for-binary beakerlib-journalcmp > beakerlib.noarch: W: no-manual-page-for-binary beakerlib-journalling > beakerlib.noarch: W: no-manual-page-for-binary beakerlib-rlMemAvg > beakerlib.noarch: W: no-manual-page-for-binary beakerlib-rlMemPeak Good suggestion. We'll try to write something for the ones which are supposed to be executed directly, not from inside Beakerlib > All these should be mode 644: > > beakerlib.noarch: W: spurious-executable-perm > /usr/share/doc/beakerlib-1.2/LICENSE > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib.1.gz > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib-analyze.1.gz > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib-beakerlib.1.gz > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib-infrastructure.1.gz > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib-journal.1.gz > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib-logging.1.gz > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib-performance.1.gz > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib-rpms.1.gz > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib-testing.1.gz > beakerlib.noarch: W: spurious-executable-perm > /usr/share/man/man1/beakerlib-virtualX.1.gz Perms fixed > 3. Shouldn't this have a 'Requires: python2' ? Seems so. Added. > 4. Should you add the examples as %doc files? Good idea, thanks! Added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review