Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591222 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #1 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-05-12 03:53:29 EDT --- koji was happy: http://koji.fedoraproject.org/koji/taskinfo?taskID=2182024 Some pedantic comments: o spec seems to follow one req/buildreq per line. However, that pattern are not used in %package devel Requires: lines. o changelog needs updating o is these lines needed (in %package devel) Provides: gail-devel = %{version}-%{release} Obsoletes: gail-devel < 2.13.0-1 o use %global over %define o %defattr(-, root, root) -> %defattr(-, root, root, -) o I am bit surprised about various hacks, push at least some of the changes upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review